https://bugzilla.redhat.com/show_bug.cgi?id=2173178 Benson Muite <benson_muite@xxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(benson_muite@emai | |lplus.org) | --- Comment #42 from Benson Muite <benson_muite@xxxxxxxxxxxxx> --- Thanks for adding the tests and your patience in getting this package into Fedora. a) Please update org.kde.kded.inotify.conf file to use just org.freedesktop.Notifications rather than * for everything. This has a security implication, and would be best to allow for least required privileges - which is why for example one does not use root, even though it would be convenient. Will check on kauth separately, figure out if something is needed to improve a secure Fedora KDE experience. b) Output of last build : https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2173178-kde-inotify-survey/fedora-rawhide-x86_64/05970727-kde-inotify-survey/fedora-review/review.txt indicates: - Sources used to build the package match the upstream source, as provided in the spec URL. Note: Upstream MD5sum check error, diff is in /var/lib/copr- rpmbuild/results/kde-inotify-survey/diff.txt See: https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/ c) Finally, in the spec file for the patch and conf file, just give the names, no need to have the url other than as a comment. Perhaps rename the patch file to something more meaningful. When creating the source rpm on your machine, provided the files are in the same directory, they should be incorporated. With those changes expect should be ok. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2173178 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
