https://bugzilla.redhat.com/show_bug.cgi?id=2208531 --- Comment #4 from Benson Muite <benson_muite@xxxxxxxxxxxxx> --- Thanks for the updates. Additional comments: a) Can you use: Source0: %{url}/archive/%{version}/%{name}-%{version}.tar.gz instead of: Source0: https://github.com/svenstaro/glsl-language-server/archive/refs/tags/%{version}.tar.gz see guidelines section on repositories: https://docs.fedoraproject.org/en-US/packaging-guidelines/ b) May want to add google test as a dependency and to enable optionally running the tests. c) Builds on all required architectures: https://copr.fedorainfracloud.org/coprs/fed500/glsl-language-server/build/5970631/ d) Request to fix some of the warnings: https://github.com/svenstaro/glsl-language-server/pull/38 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2208531 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
