Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Package review: tcl-html https://bugzilla.redhat.com/show_bug.cgi?id=427264 ------- Additional Comments From wart@xxxxxxxxxx 2008-01-02 11:48 EST ------- * The Provides: line is not needed, since this package doesn't actually provide any code. * download urls for sourceforge are best listed as: URL: http://downloads.sourceforge.net/sourceforge/tcl/tcl%{version}-html.tar.gz ...instead of using a hardcoded mirror. * The RPM group would be more accurate as 'Documentation' * A proper 'index.html' index page would be useful. A simple one can be created in either %prep or %build as a symlink to point to 'contents.htm' ln -s html/contents.htm html/index.html * Minor nitpick: I've been told by others that it's good to have an empty %build and %install section in the spec file instead of leaving them out. Apparently there are some rpm corner cases that will choke if they sections are missing. In these cases, I usually do this: %build # Nothing to build. %install # Nothing to install. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review