Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ivtv - An iTVC15/16 and CX23415/16 driver https://bugzilla.redhat.com/show_bug.cgi?id=250971 ------- Additional Comments From kwizart@xxxxxxxxx 2008-01-02 11:36 EST ------- >From the the build.log * Use of $RPM_OPT_FLAGS cc -I/builddir/build/BUILD/ivtv-1.0.3/utils/../driver -D_GNU_SOURCE -O2 -Wall -g ivtv-radio.c -o ivtv-radio This mean that our $RPM_OPT_FLAGS aren't took, there is a problem with the perl patch in %prep. Others dynamic patches in %prep that are related to the driver part could be dropped... * Missing %{?_smp_mflags} when doing make at %build step (if it do not work, you have to tell it within the spec). * Checks if Requirements are sane: Requires: /usr/bin/perl ivtv-firmware libc.so.6()(64bit) libc.so.6(GLIBC_2.2.5)(64bit) libc.so.6(GLIBC_2.3)(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libm.so.6()(64bit) libm.so.6(GLIBC_2.2.5)(64bit) libpthread.so.0()(64bit) libpthread.so.0(GLIBC_2.2.5)(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(GLIBCXX_3.4)(64bit) perl(Getopt::Long) rtld(GNU_HASH) The above line show the requirement for the ivtv package, it has /usr/bin/perl and perl(Getopt::Long) that are bring by the /usr/share/ivtv/ivtvfwextract.pl * The README.utils state that: ---------------------------------------------------- v4l2-ctl -------- This is a copy of the same utility that is available from the linux v4l-dvb repository (www.linuxtv.org). It can be used to set, list and get almost everything that the v4l2 API offers. ivtvctl ------- Similar to v4l2-ctl, but only contains ivtv-specific features. Eventually all ivtv functionality should be moved into v4l2-ctl, and then this utility will be removed. ---------------------------------------------------- So I wonder if v4l2-ctl will conflict the v4l-dvb tools. For now I think providing v4l2-ctl with ivtv is better, but we might monitor if this package will be replaced by something from http://www.video4linux.org/browser So to sum-up: there is a need to check for $RPM_OPT_FLAGS and add %{?_smp_mflags}. @Juha Tuomala - I would say if you can test it would be fine, but I have no doubt that the package works... What is checked here is about fine tuning the package against the Fedora builsystem and guidelines. Which card do you own for information ? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review