https://bugzilla.redhat.com/show_bug.cgi?id=2180418 Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+ Status|ASSIGNED |POST --- Comment #18 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- > Why do we prefer this for local builds to "rpmbuild -bs foo.spec && mock foo.src.rpm && rpmlint *.rpm"? It works fairly reliably for me. I think it's time to abandon those strenuous rpmlint checks. They were added because people needed to manage the changelog manually, so errors were made. But when this is automatized, the check should just be skipped. > Key names that start with KEY_ are keyboard layout independent constants "Layout" can refer to the "key map", i.e. what is set in /etc/vconsole.conf. The physical scan codes are independent of the keys that they map to later. (On the console, do 'localectl set-keymap fr', 'evtest /dev/input/eventX' (the keyboard), and press 'W'. evtest shows KEY_W, but we get 'z' on the console.) --- In README.Fedora: sudo systemctl enable --now input-remapper --- + package name is correct + latest version + license is acceptable for Fedora (GPL-3.0-or-later) + license is specified correctly + %pyproject is used as recommended by the python packaging guidelines + P/R/BR look OK + builds and installs OK + the program seems to work (see above) Package is APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2180418 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
