https://bugzilla.redhat.com/show_bug.cgi?id=2208737 --- Comment #11 from Phil Wyett <philip.wyett@xxxxxxxxxxxx> --- Spec URL: https://kathenas.fedorapeople.org/development/fedora/rawhide/for_review/mediastreamer2/mediastreamer2.spec SRPM URL: https://kathenas.fedorapeople.org/development/fedora/rawhide/for_review/mediastreamer2/mediastreamer2-5.2.45-1.fc39.src.rpm (In reply to Benson Muite from comment #6) > Warnings from fedora-review > > [!]: Large data in /usr/share should live in a noarch subpackage if package > is arched. > Note: Arch-ed rpms have a total of 29736960 bytes in /usr/share > mediastreamer2-devel-5.2.45-1.fc39.x86_64.rpm:29245440 > See: > > https://fedoraproject.org/wiki/Packaging: > ReviewGuidelines#Package_Review_Guidelines > > Maybe some of these files should be in a noarch data subpackage? Split tester application off into own sub-package and created a noarch tester-data sub-package. > > > - If (and only if) the source package includes the text of the license(s) > in its own file, then that file, containing the text of the license(s) > for the package is included in %license. > Note: License file mediastreamer2_license.html is not marked as %license > See: https://docs.fedoraproject.org/en-US/packaging- > guidelines/LicensingGuidelines/#_license_text > > > Other license found in the source: > No copyright* SGI Free Software License B v2.0 > ----------------------------------------------- > mediastreamer2-5.2.45/include/OpenGL/GLES2/gl2platform.h > mediastreamer2-5.2.45/include/OpenGL/GLES3/gl3platform.h > > Apache License 2.0 > ------------------ > mediastreamer2-5.2.45/src/android/AudioTrack.h > mediastreamer2-5.2.45/src/android/media/NdkMediaCodec.h > mediastreamer2-5.2.45/src/android/media/NdkMediaCrypto.h > mediastreamer2-5.2.45/src/android/media/NdkMediaDrm.h > mediastreamer2-5.2.45/src/android/media/NdkMediaError.h > mediastreamer2-5.2.45/src/android/media/NdkMediaExtractor.h > mediastreamer2-5.2.45/src/android/media/NdkMediaFormat.h > mediastreamer2-5.2.45/src/android/media/NdkMediaMuxer.h > > Apple MIT License > ----------------- > mediastreamer2-5.2.45/src/utils/opengl_debug.h > > BSD 3-Clause License > -------------------- > mediastreamer2-5.2.45/include/OpenGL/LICENSE > mediastreamer2-5.2.45/src/utils/_kiss_fft_guts.h > mediastreamer2-5.2.45/src/utils/kiss_fft.c > mediastreamer2-5.2.45/src/utils/kiss_fftr.c > > BSD 3-Clause License GNU Affero General Public License v3.0 or later > -------------------------------------------------------------------- > mediastreamer2-5.2.45/include/mediastreamer2/dsptools.h > mediastreamer2-5.2.45/src/audiofilters/macsnd.c > mediastreamer2-5.2.45/src/utils/dsptools.c > > BSD 3-Clause License GNU General Public License v2.0 or later > ------------------------------------------------------------- > mediastreamer2-5.2.45/src/audiofilters/aqsnd.m > > > Please add a license breakdown in the spec file. Done. Added to license field. Will do a deep dive here later and report to upstream. > > Kiss FFT is available in Fedora. If the one packaged in Fedora cannot be > used, should indicate that it uses a bundled Kiss FFT. Done, indicated as bundled. This is a partial of 'kiss-fft'. Will report upstream and see if we can make system 'kiss-fft' usable. Regards Phil -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2208737 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
