https://bugzilla.redhat.com/show_bug.cgi?id=2208350 --- Comment #13 from Phil Wyett <philip.wyett@xxxxxxxxxxxx> --- (In reply to Felix Wang from comment #12) > Though the patch should add a link or comment to above patch files, the > names of patch files have already explained the reasons of applying the > patch file. btw, It is beneficial to open PR on the upstream repository, so > there may not need to apply the patch files in the future. > ref: > https://docs.fedoraproject.org/en-US/packaging-guidelines/#_patch_guidelines/ > > note: There is newer release of this library, update to the latest release > when further pushing the packaging. > > Packages is approved. > > ---- > > This is a review *template*. Besides handling the [ ]-marked tests you are > also supposed to fix the template before pasting into bugzilla: > - Add issues you find to the list of issues on top. If there isn't such > a list, create one. > - Add your own remarks to the template checks. > - Add new lines marked [!] or [?] when you discover new things not > listed by fedora-review. > - Change or remove any text in the template which is plain wrong. In this > case you could also file a bug against fedora-review > - Remove the "[ ] Manual check required", you will not have any such lines > in what you paste. > - Remove attachments which you deem not really useful (the rpmlint > ones are mandatory, though) > - Remove this text > > > > Package Review > ============== > > Legend: > [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated > [ ] = Manual review needed > > > > ===== MUST items ===== > > C/C++: > [ ]: Package does not contain kernel modules. > [ ]: Package contains no static executables. > [x]: If your application is a C or C++ application you must list a > BuildRequires against gcc, gcc-c++ or clang. > [x]: Header files in -devel subpackage, if present. > [x]: ldconfig not called in %post and %postun for Fedora 28 and later. > [x]: Package does not contain any libtool archives (.la) > [x]: Rpath absent or only used for internal libs. > [x]: Development (unversioned) .so files in -devel subpackage, if present. > > Generic: > [ ]: Package successfully compiles and builds into binary rpms on at least > one supported primary architecture. > Note: Using prebuilt packages > [ ]: Package is licensed with an open-source compatible license and meets > other legal requirements as defined in the legal section of Packaging > Guidelines. > [ ]: License field in the package spec file matches the actual license. > Note: Checking patched sources after %prep for licenses. Licenses > found: "Unknown or generated", "GNU General Public License v2.0 or > later", "GNU General Public License v3.0 or later", "*No copyright* > GNU General Public License". 19 files have unknown license. Detailed > output of licensecheck in /var/lib/copr- > rpmbuild/results/belr/licensecheck.txt > [ ]: License file installed when any subpackage combination is installed. > [ ]: If the package is under multiple licenses, the licensing breakdown > must be documented in the spec. > [ ]: %build honors applicable compiler flags or justifies otherwise. > [ ]: Package contains no bundled libraries without FPC exception. > [ ]: Changelog in prescribed format. > [ ]: Sources contain only permissible code or content. > [ ]: Package contains desktop file if it is a GUI application. > [ ]: Development files must be in a -devel package > [ ]: Package uses nothing in %doc for runtime. > [ ]: Package consistently uses macros (instead of hard-coded directory > names). > [ ]: Package is named according to the Package Naming Guidelines. > [ ]: Package does not generate any conflict. > [ ]: Package obeys FHS, except libexecdir and /usr/target. > [ ]: If the package is a rename of another package, proper Obsoletes and > Provides are present. > [ ]: Requires correct, justified where necessary. > [ ]: Spec file is legible and written in American English. > [ ]: Package contains systemd file(s) if in need. > [ ]: Useful -debuginfo package or justification otherwise. > [ ]: Package is not known to require an ExcludeArch tag. > [ ]: Large documentation must go in a -doc subpackage. Large could be size > (~1MB) or number of files. > Note: Documentation size is 20480 bytes in 2 files. > [ ]: Package complies to the Packaging Guidelines > [x]: Package installs properly. > [x]: Rpmlint is run on all rpms the build produces. > Note: There are rpmlint messages (see attachment). > [x]: If (and only if) the source package includes the text of the > license(s) in its own file, then that file, containing the text of the > license(s) for the package is included in %license. > [x]: Package requires other packages for directories it uses. > [x]: Package must own all directories that it creates. > [x]: Package does not own files or directories owned by other packages. > [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT > [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the > beginning of %install. > [x]: Macros in Summary, %description expandable at SRPM build time. > [x]: Dist tag is present. > [x]: Package does not contain duplicates in %files. > [x]: Permissions on files are set properly. > [x]: Package must not depend on deprecated() packages. > [x]: Package use %makeinstall only when make install DESTDIR=... doesn't > work. > [x]: Package is named using only allowed ASCII characters. > [x]: Package does not use a name that already exists. > [x]: Package is not relocatable. > [x]: Sources used to build the package match the upstream source, as > provided in the spec URL. > [x]: Spec file name must match the spec package %{name}, in the format > %{name}.spec. > [x]: File names are valid UTF-8. > [x]: Packages must not store files under /srv, /opt or /usr/local > > ===== SHOULD items ===== > > Generic: > [!]: Reviewer should test that the package builds in mock. > [ ]: If the source package does not include license text(s) as a separate > file from upstream, the packager SHOULD query upstream to include it. > [ ]: Final provides and requires are sane (see attachments). > [ ]: Package functions as described. > [ ]: Latest version is packaged. > [ ]: Package does not include license text files separate from upstream. > [ ]: Patches link to upstream bugs/comments/lists or are otherwise > justified. > [ ]: Sources are verified with gpgverify first in %prep if upstream > publishes signatures. > Note: gpgverify is not used. > [ ]: Package should compile and build into binary rpms on all supported > architectures. > [ ]: %check is present and all tests pass. > [ ]: Packages should try to preserve timestamps of original installed > files. > [x]: Buildroot is not present > [x]: Package has no %clean section with rm -rf %{buildroot} (or > $RPM_BUILD_ROOT) > [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. > [x]: Fully versioned dependency in subpackages if applicable. > [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file > [x]: The placement of pkgconfig(.pc) files are correct. > [x]: Sources can be downloaded from URI in Source: tag > [x]: SourceX is a working URL. > [x]: Spec use %global instead of %define unless justified. > > ===== EXTRA items ===== > > Generic: > [x]: Rpmlint is run on debuginfo package(s). > Note: No rpmlint messages. > [x]: Rpmlint is run on all installed packages. > Note: There are rpmlint messages (see attachment). > [x]: Large data in /usr/share should live in a noarch subpackage if package > is arched. > > > Rpmlint > ------- > Checking: belr-5.2.45-1.fc39.x86_64.rpm > belr-devel-5.2.45-1.fc39.x86_64.rpm > belr-tools-5.2.45-1.fc39.x86_64.rpm > belr-debuginfo-5.2.45-1.fc39.x86_64.rpm > belr-debugsource-5.2.45-1.fc39.x86_64.rpm > belr-5.2.45-1.fc39.src.rpm > ============================ rpmlint session starts > ============================ > rpmlint: 2.4.0 > configuration: > /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml > /etc/xdg/rpmlint/fedora-legacy-licenses.toml > /etc/xdg/rpmlint/fedora-spdx-licenses.toml > /etc/xdg/rpmlint/fedora.toml > /etc/xdg/rpmlint/scoring.toml > /etc/xdg/rpmlint/users-groups.toml > /etc/xdg/rpmlint/warn-on-functions.toml > rpmlintrc: [PosixPath('/tmp/tmpwlasn7x4')] > checks: 31, packages: 6 > > belr-tools.x86_64: W: no-manual-page-for-binary belr-compiler > belr-tools.x86_64: W: no-manual-page-for-binary belr-parse > belr-tools.x86_64: W: no-manual-page-for-binary belr_tester > belr.x86_64: W: no-documentation > belr-tools.x86_64: W: no-documentation > 6 packages and 0 specfiles checked; 0 errors, 5 warnings, 0 badness; has > taken 0.4 s > > > > > Rpmlint (debuginfo) > ------------------- > Checking: belr-debuginfo-5.2.45-1.fc39.x86_64.rpm > belr-tools-debuginfo-5.2.45-1.fc39.x86_64.rpm > ============================ rpmlint session starts > ============================ > rpmlint: 2.4.0 > configuration: > /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml > /etc/xdg/rpmlint/fedora-legacy-licenses.toml > /etc/xdg/rpmlint/fedora-spdx-licenses.toml > /etc/xdg/rpmlint/fedora.toml > /etc/xdg/rpmlint/scoring.toml > /etc/xdg/rpmlint/users-groups.toml > /etc/xdg/rpmlint/warn-on-functions.toml > rpmlintrc: [PosixPath('/tmp/tmpx040e5j_')] > checks: 31, packages: 2 > > 2 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has > taken 0.2 s > > > > > > Rpmlint (installed packages) > ---------------------------- > ============================ rpmlint session starts > ============================ > rpmlint: 2.4.0 > configuration: > /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml > /etc/xdg/rpmlint/fedora-legacy-licenses.toml > /etc/xdg/rpmlint/fedora-spdx-licenses.toml > /etc/xdg/rpmlint/fedora.toml > /etc/xdg/rpmlint/scoring.toml > /etc/xdg/rpmlint/users-groups.toml > /etc/xdg/rpmlint/warn-on-functions.toml > checks: 31, packages: 6 > > belr-tools.x86_64: W: no-manual-page-for-binary belr-compiler > belr-tools.x86_64: W: no-manual-page-for-binary belr-parse > belr-tools.x86_64: W: no-manual-page-for-binary belr_tester > belr-tools.x86_64: W: no-documentation > belr.x86_64: W: no-documentation > 6 packages and 0 specfiles checked; 0 errors, 5 warnings, 0 badness; has > taken 0.9 s > > > > Source checksums > ---------------- > https://gitlab.linphone.org/BC/public/belr/-/archive/5.2.45/belr-5.2.45.tar. > bz2 : > CHECKSUM(SHA256) this package : > 710d6e06f439f0ed9c2576ce55a5da48236463c1eb1d759ac9350295c248b0bf > CHECKSUM(SHA256) upstream package : > 710d6e06f439f0ed9c2576ce55a5da48236463c1eb1d759ac9350295c248b0bf > > > Requires > -------- > belr (rpmlib, GLIBC filtered): > glibc > libbctoolbox.so.1()(64bit) > libc.so.6()(64bit) > libgcc_s.so.1()(64bit) > libgcc_s.so.1(GCC_3.0)(64bit) > libgcc_s.so.1(GCC_3.3.1)(64bit) > libstdc++.so.6()(64bit) > libstdc++.so.6(CXXABI_1.3)(64bit) > rtld(GNU_HASH) > > belr-devel (rpmlib, GLIBC filtered): > /usr/bin/pkg-config > belr(x86-64) > cmake-filesystem(x86-64) > libbelr.so.1()(64bit) > > belr-tools (rpmlib, GLIBC filtered): > belr(x86-64) > belr-devel(x86-64) > glibc > libbctoolbox-tester.so.1()(64bit) > libbctoolbox.so.1()(64bit) > libbelr.so.1()(64bit) > libc.so.6()(64bit) > libgcc_s.so.1()(64bit) > libgcc_s.so.1(GCC_3.0)(64bit) > libgcc_s.so.1(GCC_3.3.1)(64bit) > libstdc++.so.6()(64bit) > libstdc++.so.6(CXXABI_1.3)(64bit) > rtld(GNU_HASH) > > belr-debuginfo (rpmlib, GLIBC filtered): > > belr-debugsource (rpmlib, GLIBC filtered): > > > > Provides > -------- > belr: > belr > belr(x86-64) > libbelr.so.1()(64bit) > > belr-devel: > belr-devel > belr-devel(x86-64) > cmake(belr) > pkgconfig(belr) > > belr-tools: > belr-tools > belr-tools(x86-64) > > belr-debuginfo: > belr-debuginfo > belr-debuginfo(x86-64) > debuginfo(build-id) > libbelr.so.1-5.2.45-1.fc39.x86_64.debug()(64bit) > > belr-debugsource: > belr-debugsource > belr-debugsource(x86-64) > > > > Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23 > Command line :/usr/bin/fedora-review --no-colors --prebuilt --rpm-spec > --name belr --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg > Buildroot used: fedora-rawhide-x86_64 > Active plugins: Generic, C/C++, Shell-api > Disabled plugins: SugarActivity, Haskell, PHP, Java, Perl, fonts, Ocaml, > Python, R > Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH Thanks Felix, Appreciate the work on the review. At this time, this and other packages of the Linphone stack (not updated in Fedora for years) will not be updated to newer versions. Once the whole stack is in and working, well tested and worked updates will be made. Phil -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2208350 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
