[Bug 2208964] Review Request: python-flit-core - PEP 517 build backend for packages using Flit

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2208964

Maxwell G <maxwell@xxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |POST
              Flags|fedora-review?              |fedora-review+



--- Comment #7 from Maxwell G <maxwell@xxxxxxx> ---
- [x] The License tag reflects the package contents and uses the correct
identifiers.

Specfile adjusted to account for flit_core/versionno.py

- [x] The license text is included and marked with %license.
- [x] The package builds successfully in mock.
- [x] The package is installable (checked by fedora-review).

- [x] There are no relevant rpmlint errors.

> python3-flit-core.noarch: W: no-documentation

is justified with a specfile comment.

- [x] The package runs tests in %check.

- [x] The latest version is packaged or packaging an earlier version is
justified.

See
https://src.fedoraproject.org/rpms/python-flit/pull-request/28#comment-143079.


- [x] The packager considers avoiding confusing `%foo_name` macros. (Not a
blocker)
- [x] Libraries: The package name has a `python3-` prefix and uses the
canonical project name
- [-] Applications: A `python3-` prefix is not used
- [x] The pyproject macros are used.
- [x] There are no bundled libraries.
- [x] The package complies with the Python and general Packaging Guidelines.


Package approved! Thanks for working on this! Tell releng that they can keep me
as the main admin when you file the unretirement ticket. I added churchyard and
@python-packagers-sig as admins.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2208964
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux