[Bug 2097826] Review Request: perl-Types-ReadOnly - Type constraints and coercions for read-only data structures and locked hashes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2097826



--- Comment #2 from Michal Josef Spacek <mspacek@xxxxxxxxxx> ---
There are some issues:
* I think that block with '%if !%{defined perl_bootstrap}' is bad. There are
runtime dependencies (Type::Tiny, Type::Coercion, Types::Standard, and
Type::Library) that are in Type::Tiny dist. We need to remove if/else
(bootstrap) and we need to add this kind of bootstrap block to BuildRequire in
perl-Type-Tiny (for perl-Types-ReadOnly, is used in tests only).
* Rewrite license to SPDX
* Remove MODULE_COMPAT line

Optional:
* I am for adding comments like "Runtime:" and "Tests:" to BuildRequire list as
in other Perl modules


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2097826
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux