https://bugzilla.redhat.com/show_bug.cgi?id=2180418 Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST --- Comment #11 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- > if [ $1 -eq 1 ] && [ -x systemctl ]; then > systemctl start %{name}.service > /dev/null 2>&1 || : > fi This must to be removed. >> After six hours of hairpulling I decided to declare defeat. I tried >> different combinations of the (limited) options offered by %find_lang, >> even"--all-name", but it plainly refuses to find the files: >I don't know too much about this either. Let's leave it for now, >maybe somebody else will have some idea. /usr/lib/rpm/find-lang.sh checks only some pecific locations for the language files. This package uses different locations, so it is hard to reconcile the two. But it also has just a bunch of those files, so I think it's OK to just ignore the issue (%lang attribute is not applied). > URL: https://github.com/sezanzeb https://github.com/sezanzeb/input-remapper would be better. /usr/share/doc/input-remapper/README.md is not useful for Fedora users. It describes how to install the package from the web and knows nothing about the ready-to-install rpm. My suggestion would be to add a README.Fedora file that mentions 'dnf install input-remapper', and 'systemctl enable --now input-remapper' and gives some instructions how to start configuring the service under gnome-shell and other systems. With the above changes: + package name is correct + license is acceptable for Fedora (GPL-3.0-or-later) + license is specified correctly + P/R/BR look OK + builds and installs OK + the program seems to work (*). (*) I did a very simple test that remapping 'x' to 'KEY_BACKSLASH' works as expected for a user logged in with gnome. I also wanted to remap to KEY_A, but the dialog says KEY_A is not valid. It seems something is buggy about the listing of the keys, and more complicated keys like KEY_BACKSLASH are accepted, but simple ones like KEY_A are not. But it's also possible I misunderstood the interface, I wasn't trying very hard. Anyway, the packaging is OK. Whether the package has bugs is not in scope of the review, so I only did some very superficial check. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2180418 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
