[Bug 2188970] Review Request: arianna - EPub Reader for mobile devices

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2188970

Benson Muite <benson_muite@xxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|needinfo?(benson_muite@emai |
                   |lplus.org)                  |



--- Comment #17 from Benson Muite <benson_muite@xxxxxxxxxxxxx> ---
The basic tests work when using kde-src build to create the executable, but
it seems something more is needed when building within Fedora. Can probably
remove %ctest as it does not do anything.  Seems very few KDE apps run tests.

Following
https://docs.fedoraproject.org/en-US/packaging-guidelines/AppData/#_app_data_validate_usage
can you move the %check section after install and also use appstream-util
validate-relax:
%check
desktop-file-validate
%{buildroot}/%{_datadir}/applications/org.kde.arianna.desktop
appstream-util validate-relax --nonet
%{buildroot}%{_kf5_metainfodir}/org.kde.arianna.appdata.xml


Will need to add
BuildRequires: libappstream-glib

It built on aarch64:
https://copr.fedorainfracloud.org/coprs/fed500/arianna/build/5939566/


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2188970
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux