https://bugzilla.redhat.com/show_bug.cgi?id=2148993 --- Comment #2 from Neal Gompa <ngompa13@xxxxxxxxx> --- Initial spec review: > License: BSD This is no longer valid. Please use SPDX-based identifiers that match the project's license. Cf. https://docs.fedoraproject.org/en-US/legal/license-field/ Cf. https://docs.fedoraproject.org/en-US/legal/all-allowed/ > Version: 1.0 > Release: 1.%{?date0}git%{?shortcommit0}%{?dist} Please move the snapshot information to the Version: field. Cf. https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/#_snapshots > Group: Development/Libraries Not needed and can be dropped. https://fedoraproject.org/wiki/RPMGroups > ExclusiveArch: x86_64 What about this restricts it to x86_64? I don't see anything in the codebase for it... > Requires: wget What is this for? > %cmake -DCMAKE_INSTALL_PREFIX=/usr \ The "CMAKE_INSTALL_PREFIX" option is already set by %cmake, so drop this. > cd %{__cmake_builddir} > %__make runtest Would "%cmake_build --target runtest" work here? Alternatively, "%{__make} -C %{__cmake_builddir} runtest" would work. > %{_libdir}/lib%{name}proto.a We don't typically package static link libraries... -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2148993 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
