[Bug 2203544] Review Request: python-ndindex - Python library for manipulating indices of ndarrays

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2203544



--- Comment #9 from Miro Hrončok <mhroncok@xxxxxxxxxx> ---
(In reply to Zbigniew Jędrzejewski-Szmek from comment #4)
> This is my spec file:
> https://in.waw.pl/~zbyszek/fedora/python-ndindex.pyproject.spec
> The first build fails because pytest is not installed.

There is no information whenever in the spec that would instruct RPM to install
pytest.
Upstream lists it in setup.py tests_require only:
https://github.com/Quansight-Labs/ndindex/blob/1.7/setup.py#L60
This is not supported by our macros and generally is a deprecated way of
specifying tests deps upstream. I'd suggest a [test] extra upstream or BR
pytest manually if upstream involvement would be too much to ask.

> I then install python3-pytest manually, and it fails because
> python3-hypothesis is missing.

Same.

> After that, the tests pass, and the failure is:
> error: Empty %files file
> /builddir/build/BUILD/ndindex-1.7/debugsourcefiles.list
> Oh, that is because it's also missing python3-Cython.

Upstream dos not list Cython dependency at all. I'd suggest listing it in
pyproject.toml (which upstream dos not yet have) or BR it manually.

> Once that is also installed, the package is generated correctly.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2203544
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux