https://bugzilla.redhat.com/show_bug.cgi?id=2188653 --- Comment #9 from Sandro <gui1ty@xxxxxxxxxxxxx> --- Thanks for the review! >- The python3 package should be named 'python3-vkbasalt-cli' not 'python-python3-vkbasalt-cli' Indeed it should. An oversight after renaming the package to python-vkbasalt-cli. Now fixed. >- Would it make sense to Requires: vkBasalt? Probably. Since this is a dependency for Bottles, I assume Bottles makes use of vkbasalt somehow. But it has no dependency on the package whatsoever. Since it doesn't hurt, I added it as a requirement. I also switched the source of the package to PyPI, currently maintained by moi. ;-) Spec URL: https://download.copr.fedorainfracloud.org/results/gui1ty/bottles/fedora-rawhide-x86_64/05931837-python-vkbasalt-cli/python-vkbasalt-cli.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/gui1ty/bottles/fedora-rawhide-x86_64/05931837-python-vkbasalt-cli/python-vkbasalt-cli-3.1.1.post1-1.fc39.src.rpm Copr build: https://copr.fedorainfracloud.org/coprs/gui1ty/bottles/build/5931837/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2188653 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
