https://bugzilla.redhat.com/show_bug.cgi?id=2207838 --- Comment #9 from Neal Gompa <ngompa13@xxxxxxxxx> --- Spec review: > BuildRequires: git-core > BuildRequires: meson gcc libxml2 pkgconf-pkg-config systemd-devel > BuildRequires: python3 python3-attrs python3-jinja2 > BuildRequires: python3-rpm-macros Having each dependency on its own line is preferred, since it makes easier to diff over time > %package -n libeis-devel > Summary: Library for Emulated Input Serverse Development Package > Requires: %{name}%{?_isa} = %{version}-%{release} This must require libeis, not libei > %package -n liboeffis-devel > Summary: Library for XDG RemoteDesktop Portal Setup Development Package > Requires: %{name}%{?_isa} = %{version}-%{release} This must require liboeffis, not libei > %ldconfig_scriptlets This can be dropped because it doesn't do anything since RHEL 8 / Fedora 28. > %doc COPYING This must be "%license COPYING". -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2207838 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
