https://bugzilla.redhat.com/show_bug.cgi?id=2185424 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #9 from Petr Pisar <ppisar@xxxxxxxxxx> --- Source0 archive (SHA-512: 442603d7bfa0edb7ffb2bb65b3b9b82b530cd9d22c6568979f4d681754902726952d2887f844e76b42bc7289f67d12bb57fd94017205394e4461e3bfdbb9bf3b) is original. Ok. Bzip2 archive content is identical to gzip archive content. Ok. License is Ok. $ rpmlint bctoolbox.spec ../SRPMS/bctoolbox-5.2.45-1.fc39.src.rpm ../RPMS/x86_64/bctoolbox-* ======================================== rpmlint session starts ======================================= rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 8 bctoolbox-tester.x86_64: W: no-manual-page-for-binary bctoolbox_tester bctoolbox.x86_64: W: no-documentation bctoolbox-tester.x86_64: W: no-documentation ========= 7 packages and 1 specfiles checked; 0 errors, 3 warnings, 0 badness; has taken 0.7 s ======== rpmlint is Ok. $ rpm -q --requires -p ../RPMS/x86_64/bctoolbox-devel-5.2.45-1.fc39.x86_64.rpm | sort -f | uniq -c 1 /usr/bin/pkg-config 1 bctoolbox(x86-64) = 5.2.45-1.fc39 1 bctoolbox-tester(x86-64) = 5.2.45-1.fc39 1 cmake-filesystem(x86-64) 1 libbctoolbox-tester.so.1()(64bit) 1 libbctoolbox.so.1()(64bit) 1 pkgconfig(bcunit) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsZstd) <= 5.4.18-1 TODO: The useless pkgconfig(bcunit) dependency is here generated probably because of "Requires.private: bcunit" line in /usr/lib64/pkgconfig/bctoolbox-tester.pc. Ask upstream to exclude this line if a static library is not built. Before then you can filter out the RPM dependency with __exclude_requires macro <https://docs.fedoraproject.org/en-US/packaging-guidelines/AutoProvidesAndRequiresFiltering/>. The package builds in F39 (https://koji.fedoraproject.org/koji/taskinfo?taskID=101249486). Ok. Otherwise, this package is in line with Fedora packaging guidelines. Please consider fixing the TODO item before building this package. Resolution: Package APPROVED. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2185424 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
