[Bug 2179404] Review Request: openvkl - Intel Open Volume Kernel Library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2179404



--- Comment #14 from Petr Pisar <ppisar@xxxxxxxxxx> ---
FIX: The current Source0 URL returns "404 Not Found" error. You need to remove
the "%{name}-" part.

> tbb-devel and zlib-devel mentioned in superbuild but those deps comes from rkcommon + openvdb cmake files.

If openvdb cmake file requires tbb-devel, then openvdb-devel RPM package must
run-require tbb-devel. It's not so:

$ rpm -q --requires openvdb-devel
libopenvdb.so.10.0()(64bit)
openvdb-libs(x86-64) = 10.0.1-5.fc39
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(FileDigests) <= 4.6.0-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(PayloadIsZstd) <= 5.4.18-1

Looking at openvdb headers:

$ grep -hr '# *include' /usr/include/openvdb | sort -u | grep tbb
#include <tbb/blocked_range2d.h>
#include <tbb/blocked_range3d.h>
#include <tbb/blocked_range.h>
#include <tbb/blocked_range.h> // for tbb::split
#include <tbb/blocked_range.h>             // threading
#include <tbb/combinable.h>
#include <tbb/concurrent_hash_map.h>
/// #include <tbb/concurrent_hash_map.h>
#include <tbb/concurrent_vector.h>
#include <tbb/enumerable_thread_specific.h>
#include <tbb/null_mutex.h>
#include <tbb/parallel_for.h>
#include <tbb/parallel_for.h>              // threading
#include <tbb/parallel_invoke.h>
#include <tbb/parallel_reduce.h>
#include <tbb/parallel_sort.h>
#include <tbb/partitioner.h>
#include <tbb/spin_mutex.h>
#include <tbb/task_arena.h>
#include <tbb/task_group.h>
#include <tbb/task.h>

They indeed include tbb headers. Hence I conclude it's a bug in openvdb-devel.
The dependency on tbb-devel should be added to openvdb-devel. Not to
openvkl.spec. In RPM we specify direct dependencies, not transitive
dependencies.

Or can you see any other reason, why openvkl should directly depend on
tbb-devel?

With zlib it's even simpler: Neither openvdb-devel headers, nor openvkl sources
include zlib headers. So the dependency shouldn't be there at all.

rkcommon-devel is the same case.

In my opinion both openvdb and rkcommon are wrongly packaged. Bugs to add a
dependency on tbb-devel and cmake files not to require zlib should be open
against them.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2179404
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux