https://bugzilla.redhat.com/show_bug.cgi?id=2166379 --- Comment #17 from Jan Staněk <jstanek@xxxxxxxxxx> --- (In reply to Zbigniew Jędrzejewski-Szmek from comment #16) > Why not %autorelease and %autochangelog? > It is the recommended default now. Because it does not really work without proper dist-git repository setup. I currently have the package in a plain git repo and build it using local mock; the release is reset to 1 and the changelog just reads 'Local build' when I try to convert to rpmautospec. But good point, I will make (hopefully) one final SRPM for the review which will use rpmautospec; this I can then just import into Fedora and start with a fresh history. > > BuildRequires: git > You could use just 'git-core' to save a few bytes. But actually, git is not > needed at all. Drop this line and '-S git_am' below. That's by design, I prefer to let git manage application of my patches (and having it properly setup if I need to adjust them in the future). Switching to git-core though to save the build system some space. > Hmm, build fails here: > diff -wur > /builddir/build/BUILD/wasi-libc-wasi-sdk-19/expected/wasm32-wasi/predefined- > macros.txt > /builddir/build/BUILD/sysroot/share/wasm32-wasi/predefined-macros.txt > --- > /builddir/build/BUILD/wasi-libc-wasi-sdk-19/expected/wasm32-wasi/predefined- > macros.txt 2023-01-09 17:33:58.000000000 +0100 > +++ /builddir/build/BUILD/sysroot/share/wasm32-wasi/predefined-macros.txt > 2023-05-13 23:56:33.729836312 +0200 > @@ -2480,6 +2480,10 @@ > #define __compiler_ATOMIC_SHORT_LOCK_FREE 2 > #define __GCC_ATOMIC_TEST_AND_SET_TRUEVAL 1 > #define __compiler_ATOMIC_WCHAR_T_LOCK_FREE 2 > +#define __GCC_HAVE_SYNC_COMPARE_AND_SWAP_1 1 > +#define __GCC_HAVE_SYNC_COMPARE_AND_SWAP_2 1 > +#define __GCC_HAVE_SYNC_COMPARE_AND_SWAP_4 1 > +#define __GCC_HAVE_SYNC_COMPARE_AND_SWAP_8 1 > #define __GNUC_STDC_INLINE__ 1 > #define __GNUC_VA_LIST 1 > #define __GXX_ABI_VERSION 1002 > make: *** [Makefile:674: check-symbols] Error 1 > error: Bad exit status from /var/tmp/rpm-tmp.LaaCtr (%build) > Bad exit status from /var/tmp/rpm-tmp.LaaCtr (%build) Those are new definitions from clang 16; upstream patch that addresses that has been applied. The hopefully final files for the review should thus be these: Spec file: https://download.copr.fedorainfracloud.org/results/jstanek/wasi-libc/fedora-rawhide-x86_64/05923687-wasi-libc/wasi-libc.spec SRPM: https://download.copr.fedorainfracloud.org/results/jstanek/wasi-libc/fedora-rawhide-x86_64/05923687-wasi-libc/wasi-libc-19-1.fc39.src.rpm -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2166379 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
