[Bug 2193370] Review Request: rang - Header-only C++ library for terminal goodies

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2193370



--- Comment #3 from Artur Frenszek-Iwicki <fedora@xxxxxxxxxx> ---
> You do not need use %define here, just put the summary words in the Summary field, and you can use %{summary} later.
Hmm. Weird. I swear I saw some cases where a sub-package did the "Summary:
%{summary}" thing and ended up with the macro not expanding.
But I tested it out and it seems to work fine.

> The dependencies of gcc, cmake and make should not be included in %if conditionals here.
Right. Initially I wanted to install stuff manually and only use cmake for
tests.

spec: https://suve.fedorapeople.org/review/rang-3.2-2/rang.spec
srpm: https://suve.fedorapeople.org/review/rang-3.2-2/rang-3.2-2.fc38.src.rpm
koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=101197450


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2193370
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux