https://bugzilla.redhat.com/show_bug.cgi?id=2193407 --- Comment #6 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Thanks for the review! (In reply to blinxen from comment #4) > Taking this review > > General comments: > > - Package was generated with rust2rpm and a manual patch was applied > - Tests were deactivated because they require the crate `ed25519-dalek` but > `ed25519-dalek` requires `ed25519` --> dependency loop. Are you going to > package `ed25519-dalek` next and reactivate the tests? I think we need to package ed25519-dalek for other reasons anyway, so I will enable tests in this crate once that's done. > - Some features were deactivated because the `pkcs8` crate in fedora is too > old. Is there a reason why `pkcs8` cannot be updated? Yeah :( rust-pkcs8 can't be updated past version 0.7.6 because rust-rsa v0.5.0 depends on pkcs8 < 0.8, and rust-rsa can't be updated because dbus-parsec depends on ancient version of rust-rsa ... I might need to poke upstream again to bump this dependency, but that's four edges removed from the problem I'm trying to solve currently, so it's rather low priority. > > I have packaged v1.5.3 on purpose (instead of the latest v2), as that is the most recent version which is compatible with requirements of the "sodiumoxide" crate > > I guess this is OK. The package can still be updated later if someone > requires v2. Yeah, package will be updated once that's possible. > APPROVED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2193407 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
