https://bugzilla.redhat.com/show_bug.cgi?id=2196711 --- Comment #5 from Neal Gompa <ngompa13@xxxxxxxxx> --- (In reply to Carl George 🤠 from comment #4) > Please list the license explicitly in %files. Using a glob for this as it > currently does means that a new upstream version can add a new license file, > and there will be no indication that the License field of the package needs > to be updated accordingly. > > -%license LICENSES/* > +%license LICENSES/GPL-2.0-or-later.txt > This will not change anything either, because %license doesn't work like other directives: it copies the file from the source tree into /usr/share/licenses/%{name}. I'd prefer to keep the glob and check as new releases come in instead. > ============================================================================= > === > > The AppData file is not being validated. Add this to %check. > > +appstream-util validate-relax --nonet > %{buildroot}%{_kf5_metainfodir}/org.kde.%{name}.appdata.xml > > https://docs.fedoraproject.org/en-US/packaging-guidelines/AppData/ > #_app_data_validate_usage > > ============================================================================= > === > > The Desktop file is not being validated. Add this to %check. > > +desktop-file-validate > %{buildroot}%{_kf5_datadir}/applications/org.kde.%{name}.desktop > > https://docs.fedoraproject.org/en-US/packaging-guidelines/ > #_desktop_file_install_usage Taken care of. I've updated the spec and SRPM in place. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2196711 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
