https://bugzilla.redhat.com/show_bug.cgi?id=2186844 --- Comment #3 from Fabio Valentini <decathorpe@xxxxxxxxx> --- (In reply to blinxen from comment #2) > Taking this review > > Generic comments: > > - Package was generated with rust2rpm and a manual patch was applied > - `sequoia-net` was bumped to `0.27.0` because this is the latest version in > fedora --> Manual patch is OK (This is not needed in the latest version) Yes, I will drop this patch as soon as I'm able to bump to the latest version. > - I assume that you want to support multiple backends, and not just the > default one, in this package --> Manual patch is OK Yes, the patch is there to make it easier to choose the crypto backend for building this crate, running tests against different backends, and for dependent packages to be able to choose a backend independently. As far as I know, the Sequoia PGP project is making similar changes in most of their projects, so the patch might not even be needed for long. > Issues: > > - Latest version is `0.3.2`, packaged version is `0.2.0`. Can this be > updated to the latest version or is `0.2.0` required? I was hoping to package v0.2.0 for sequoia-sq v0.29.0, but since I figured out most of the things that would be needed to do that and filed all the requests, new releases have been published ... If it is alright with you, I'd like to stick with v0.2.0 and get sequoia-sq updated to v0.29.0 first, and I'll push follow-up updates to this package and sequoia-sq v0.30.0. The package is a bit hard to keep track of, since the project tends to add new dependencies with every version :( > - fedora-review shows (see below) that `rust-sequoia-cert-store-devel` > requires `/usr/bin/bash`. I am not sure where it got that as this is not > mentioned in the spec file. Is this some rpm auto require magic? Probably ... let me check. Yes, it's probably caused by the "tests/cert2rust.sh" script, which has a "#!/bin/bash" shebang. I'll exclude the "tests" directory from installed files, which should prevent this issue. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2186844 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
