Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gtkimageview - Simple image viewer widget https://bugzilla.redhat.com/show_bug.cgi?id=427096 nphilipp@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs? ------- Additional Comments From nphilipp@xxxxxxxxxx 2007-12-31 15:03 EST ------- (In reply to comment #1) > Except for > - duplicate BuildRequires: pkgconfig (by glib2-devel), glib2-devel (by gtk2-devel) I've made it a (private) policy of mine to at least attempt to include all direct dependencies needed for building, even those that are in turn required by other dependencies higher up in the chain. Gtkimageview uses glib-genmarshal (from glib2-devel) and pkg-config (from pkgconfig) directly. > - strange name of source That's because upstream attaches the source tarballs to a Trac wiki page. To download them directly, Trac wants the '?format=raw' suffix. Since rpmbuild has no problems with that, I chose to do it this way e.g. to allow spectool to work properly. Inelegant, but working ;-). > ================ > *** APPROVED *** > ================ > > > How about creating a separate package with the rest of the stuff which is built > anyway, at least the /html dir ? The HTML documentation is in the -devel subpackage in /usr/share/gtk-doc/html/gtkimageview -- or do you mean something else? Thanks for the prompt review and have a good year 2008! ------------------- New Package CVS Request ======================= Package Name: gtkimageview Short Description: Simple image viewer widget Owners: nphilipp Branches: F-7 F-8 Cvsextras Commits: yes -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review