https://bugzilla.redhat.com/show_bug.cgi?id=2182063 Maxwell G <maxwell@xxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value Assignee|nobody@xxxxxxxxxxxxxxxxx |maxwell@xxxxxxx Flags| |fedora-review? Status|NEW |ASSIGNED CC| |maxwell@xxxxxxx --- Comment #2 from Maxwell G <maxwell@xxxxxxx> --- Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated - [x] The License tag reflects the package contents and uses the correct identifiers. - [!] The license text is included and marked with %license. - [x] The package builds successfully in mock. - [x] Package is installable (checked by fedora-review). - [!] There are no relevant rpmlint errors. > python3-immutabledict.noarch: W: no-documentation Please include the README in the package. - [x] The package runs tests in %check. Yes, but if you're going to add a check bcond, then you should also conditionalize the `BuildRequires: pytest`. I'd change ``` BuildRequires: pytest ``` to ``` %if %{with check} BuildRequires: python3-pytest %endif ``` - [!] The latest version is packaged or packaging an earlier version is justified. The latest version is 2.2.4. - [!] Packager considers avoiding confusing `%foo_name` macros. (Not a blocker) I'd suggest removing ``` %global modname immutabledict ``` and just use the literal value everywhere. - [x] Libraries: The package name has a `python3-` prefix and uses the canonical project name - [-] Applications: A `python3-` prefix is not used - [x] The pyproject macros are used - [x] There are no bundled libraries - [!] The package complies with the Python and general Packaging Guidelines. The missing license texts are a problem. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2182063 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
