https://bugzilla.redhat.com/show_bug.cgi?id=2196848 --- Comment #4 from Fabio Valentini <decathorpe@xxxxxxxxx> --- (In reply to Peter Robinson from comment #3) > > This is actually not a pointless failure, the src/lib.rs file is just marked > > as executable when it shouldn't be, which triggers the script processing. > > Fixing it doesn't even need a patch, doing "chmod -x src/lib.rs" in %prep is > > enough. > > Fair enough, although the error could probably be more useful I agree 😅 > > On the other hand, the fact that the project doesn't have a LICENSE file > > (neither in published sources, nor in the upstream GitHub project) is indeed > > a problem for MIT license. > > I've now reported that upstream and added the ticket as a comment (I thought > rust2rpm used to warn on this, may be misremembering). Thanks! In fact, rust2rpm *does* warn, in two places: It prints a red error message to stderr when there's no license files detected, and it inserts a "# FIXME: no license files detected" comment into the spec file. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2196848 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
