[Bug 2196848] Review Request: rust-serde_tuple_macros - De/serialize structs with named fields as array of values

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2196848

Fabio Valentini <decathorpe@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |decathorpe@xxxxxxxxx



--- Comment #2 from Fabio Valentini <decathorpe@xxxxxxxxx> ---
Two quick comments from Rust packaging POV:

> # A patch to work around the following pointless rpm build failure
> # *** ERROR: ./usr/share/cargo/registry/serde_tuple_macros-0.5.0/src/lib.rs has shebang which doesn't start with '/' ([recursion_limit = "4096"])

This is actually not a pointless failure, the src/lib.rs file is just marked as
executable when it shouldn't be, which triggers the script processing.
Fixing it doesn't even need a patch, doing "chmod -x src/lib.rs" in %prep is
enough.

On the other hand, the fact that the project doesn't have a LICENSE file
(neither in published sources, nor in the upstream GitHub project) is indeed a
problem for MIT license.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2196848
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux