https://bugzilla.redhat.com/show_bug.cgi?id=2192597 --- Comment #19 from Carl George 🤠 <carl@xxxxxxxxxx> --- > I interpreted your last comment to mean I need to explicitly set release number and update changelog in the spec file as fedpkg won't work with %autochangelog/%autorelease, so did that. No that's not what I meant, sorry for the confusion. You could have had the initial import commit use %autorelease/%autochangelog with no changelog file. fedpkg works fine with those macros, but when using `fedpkg mockbuild` the resulting spec file inside the SRPM will have the macros expanded (for compatibility reasons, I think). Looking a bit closer, I think `fedpkg import` should have refused to import that SRPM based on this code in rpkg, the underlying library it uses. https://pagure.io/rpkg/c/3087dd72e933568896b2f167bab75194482a6cd1 But your initial import has the macros, so I'm not sure what happened. Did you import the SRPM from `fedpkg mockbuild`, or something else? I'm going to have to dig into this one a bit more and get back to you about the correct steps to take. Sorry again you hit this rough edge. The spec file is totally fine as it currently is in distgit. > So should I understand it correctly that this is the correct way to add changelogs and bump versions, or is there some way to switch to having it be automated now that I've made an initial build? >From here you could do a few things. You could just keep writing changelog entries (rpmdev-bumpspec from rpmdevtools helps with this). Or you could switch to the rpmautospec macros by running `rpmdevautospec convert`. This will create a commit that adds the macros and moves the existing changelog entries to a changelog file. Ideally you would run this right before bumping the version in the spec file. https://docs.pagure.org/fedora-infra.rpmautospec/opting-in.html#for-existing-packages -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2192597 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
