https://bugzilla.redhat.com/show_bug.cgi?id=2193124 Miro Hrončok <mhroncok@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mhroncok@xxxxxxxxxx --- Comment #2 from Miro Hrončok <mhroncok@xxxxxxxxxx> --- > Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. Seems like %make_install installs %{_sysconfdir}/xdg/autostart/%{name}.desktop, so add desktop-file-validate to %check. See https://docs.fedoraproject.org/en-US/packaging-guidelines/#_desktop_file_install_usage cronopete.src: W: no-url-tag cronopete.x86_64: W: no-url-tag Add URL: to spec. cronopete.src: W: summary-ended-with-dot A backup utility for Linux. cronopete.x86_64: W: summary-ended-with-dot A backup utility for Linux. Remove the dot. cronopete.x86_64: E: devel-dependency glibc-devel Why is this Required by a backup utility? cronopete.x86_64: E: explicit-lib-dependency glib2 cronopete.x86_64: E: explicit-lib-dependency libappindicator-gtk3 cronopete.x86_64: E: explicit-lib-dependency libdbusmenu cronopete.x86_64: E: explicit-lib-dependency libgee cronopete.x86_64: E: explicit-lib-dependency libnotify cronopete.x86_64: E: explicit-lib-dependency libudisks2 The package requires: cronopete (rpmlib, GLIBC filtered): /bin/sh /usr/bin/sh atk cairo-gobject gdk-pixbuf2 glib2 glibc-devel gtk3 libappindicator-gtk3 libappindicator3.so.1()(64bit) libatk-1.0.so.0()(64bit) libc.so.6()(64bit) libcairo-gobject.so.2()(64bit) libcairo.so.2()(64bit) libdbusmenu libdbusmenu-glib.so.4()(64bit) libgdk-3.so.0()(64bit) libgdk_pixbuf-2.0.so.0()(64bit) libgee libgee-0.8.so.2()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgtk-3.so.0()(64bit) libharfbuzz.so.0()(64bit) libnotify libnotify.so.4()(64bit) libpango-1.0.so.0()(64bit) libpangocairo-1.0.so.0()(64bit) libudisks2 libudisks2.so.0()(64bit) libz.so.1()(64bit) pango rsync rtld(GNU_HASH) So the manual Requires that are covered by the automatic one need to be removed. See https://docs.fedoraproject.org/en-US/packaging-guidelines/#_explicit_requires cronopete.x86_64: W: file-not-in-%lang /usr/share/locale/cs/LC_MESSAGES/cronopete.mo cronopete.x86_64: W: file-not-in-%lang /usr/share/locale/de/LC_MESSAGES/cronopete.mo cronopete.x86_64: W: file-not-in-%lang /usr/share/locale/es/LC_MESSAGES/cronopete.mo cronopete.x86_64: W: file-not-in-%lang /usr/share/locale/fr/LC_MESSAGES/cronopete.mo cronopete.x86_64: W: file-not-in-%lang /usr/share/locale/gl/LC_MESSAGES/cronopete.mo cronopete.x86_64: W: file-not-in-%lang /usr/share/locale/pt_BR/LC_MESSAGES/cronopete.mo cronopete.x86_64: W: file-not-in-%lang /usr/share/locale/ru/LC_MESSAGES/cronopete.mo See https://docs.fedoraproject.org/en-US/packaging-guidelines/#handling_locale_files cronopete.x86_64: W: files-duplicate /usr/share/icons/hicolor/scalable/status/cronopete-arrow-1-white-symbolic.svg /usr/share/icons/hicolor/scalable/apps/cronopete-arrow-1-white.svg cronopete.x86_64: W: files-duplicate /usr/share/icons/hicolor/scalable/status/cronopete-arrow-2-white-symbolic.svg /usr/share/icons/hicolor/scalable/apps/cronopete-arrow-2-white.svg cronopete.x86_64: W: files-duplicate /usr/share/icons/hicolor/scalable/status/cronopete-arrow-3-white-symbolic.svg /usr/share/icons/hicolor/scalable/apps/cronopete-arrow-3-white.svg cronopete.x86_64: W: files-duplicate /usr/share/icons/hicolor/scalable/status/cronopete-arrow-4-white-symbolic.svg /usr/share/icons/hicolor/scalable/apps/cronopete-arrow-4-white.svg Consider linking those, but it's not required. cronopete.x86_64: W: no-manual-page-for-binary cronopete cronopete.x86_64: W: no-manual-page-for-binary cronopete_preferences.sh cronopete.x86_64: W: no-manual-page-for-binary cronopete_restore.sh Meh. cronopete.x86_64: W: non-conffile-in-etc /etc/xdg/autostart/cronopete.desktop Mark this file as %config(norepalce). See https://docs.fedoraproject.org/en-US/packaging-guidelines/#_configuration_files cronopete.x86_64: W: position-independent-executable-suggested /usr/bin/cronopete cronopete.x86_64: W: unstripped-binary-or-object /usr/bin/cronopete cronopete.x86_64: W: unused-direct-shlib-dependency /usr/bin/cronopete /lib64/libatk-1.0.so.0 cronopete.x86_64: W: unused-direct-shlib-dependency /usr/bin/cronopete /lib64/libdbusmenu-glib.so.4 cronopete.x86_64: W: unused-direct-shlib-dependency /usr/bin/cronopete /lib64/libharfbuzz.so.0 cronopete.x86_64: W: unused-direct-shlib-dependency /usr/bin/cronopete /lib64/libudisks2.so.0 cronopete.x86_64: W: unused-direct-shlib-dependency /usr/bin/cronopete /lib64/libz.so.1 This indicates Feora build flags were not used, or prebuilt content was shipped. Investigate the cmake things and try to figure out how to pass in the standard flags from Fedora. Drop %global debug_package %{nil} -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2193124 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
