https://bugzilla.redhat.com/show_bug.cgi?id=2192597 --- Comment #2 from Carl George 🤠 <carl@xxxxxxxxxx> --- The License tag is using the old GPLv2+ identifier. It's required to use the new SPDX identifier, which in this case is GPL-2.0-or-later. https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_valid_license_short_names ================================================================================ Upstream has two different licenses in their setup.cfg file. license = GPLv2 or later https://github.com/breezy-team/setuptools-gettext/blob/v0.1.3/setup.cfg#L6 License :: OSI Approved :: Apache Software License https://github.com/breezy-team/setuptools-gettext/blob/v0.1.3/setup.cfg#L14 Can you open an issue with them to get clarification on what the intended license is, so we can make sure the package is marked correctly? ================================================================================ What is the purpose of the ExclusiveArch tag? The dependencies appear to be available on all architectures, so I can't see why this would be necessary. ================================================================================ Speaking of dependencies, I don't see any mention in the the source code of semantic-version, typing-extensions, or wheel. The comment about setuptools_scm and wheel doesn't seem to be relevant (or accurate, as RHEL 8 and 9 have both of those). ================================================================================ You mentioned building this for EPEL 8. RHEL 8 only has setuptools 39.2.0, but this software and the spec file set a minimum version of 46.1. That minimum has been upstream since the initial commit. I don't actually think it's accurate. After patching it out I was able to build this spec file for EPEL 8. I recommend adding this line to %prep. sed -e 's/setuptools>=46.1/setuptools/' -i setup.cfg ================================================================================ There is a macro to do an import test in %check, it would be better to switch to that instead of the manual import. %py3_check_import setuptools_gettext -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2192597 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
