https://bugzilla.redhat.com/show_bug.cgi?id=2192186 --- Comment #2 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> --- Source file is ok Summary is ok Description is ok All tests passed BuildRequires are ok License FIX: Convert a License tag to SPDX format. Fedora moved a license syntax to SPDX https://docs.fedoraproject.org/en-US/legal/license-field/#_perl_packages. URL and Source0 FIX: Please switch Source and URL from www.cpan.org to metacpan.org https://metacpan.org/dist/Test-Future-IO-Impl/ https://cpan.metacpan.org/authors/id/P/PE/PEVANS/Test-Future-IO-Impl-%{version}.tar.gz FIX: Add 'Conflicts: perl-Future-IO < 0.14' $ rpm -qp --requires perl-Test-Future-IO-Impl-0.14-1.fc39.noarch.rpm | sort | uniq -c | grep -v rpmlib 1 perl(Errno) 1 perl(Exporter) 1 perl(IO::Handle) 1 perl-libs 1 perl(:MODULE_COMPAT_5.36.1) 1 perl(Socket) 1 perl(Test2::API) 1 perl(Test2::V0) 1 perl(Time::HiRes) 1 perl(:VERSION) >= 5.14.0 1 perl(warnings) Binary requires FIX: Please add run-require - perl(IO::Socket::INET) - lib/Test/Future/IO/Impl.pm:109,147 FIX: Remove "Requires: perl(:MODULE_COMPAT_..." line from the spec file. The dependency is now automatically generated with perl-generators. https://docs.fedoraproject.org/en-US/packaging-guidelines/Perl/#_versioned_module_compat_requires_or_perl_libs $ rpm -qp --provides perl-Test-Future-IO-Impl-0.14-1.fc39.noarch.rpm | sort | uniq -c 1 perl(Test::Future::IO::Impl) = 0.14 1 perl-Test-Future-IO-Impl = 0.14-1.fc39 Binary provides are Ok. $ rpmlint ./perl-Test-Future-IO-Impl* ================================== rpmlint session starts =============================== rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 3 === 2 packages and 1 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.2 s Rpmlint is ok Otherwise the package is in line with Fedora and Perl packaging guide lines. Please correct all 'FIX' items and provide a new spec file. Resolution: Not Approved -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2192186 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
