https://bugzilla.redhat.com/show_bug.cgi?id=2183860 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |decathorpe@xxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |decathorpe@xxxxxxxxx Flags| |fedora-review? --- Comment #1 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Package looks good to me, with one exception: The crate seems to bundle "Cantarell Regular" font (at "/src/title/Cantarell-Regular.ttf"). After a quick look at the code, it looks like this file is only embedded as a fallback font if the system font can't be loaded ... either way, it should be possible to un-bundle this file at build-time (i.e. add something like `BuildRequires: font(cantarell)`, and replace the path in the include_bytes! macro (in src/title/ab_glyph_render.rs:12) with the path to the system copy). Additionally, v0.6.0 of this crate has been released - but if you need v0.5.* for alacritty, then keeping this package at <0.6.0 for now is fine. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2183860 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
