https://bugzilla.redhat.com/show_bug.cgi?id=2179404 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@xxxxxxxxxxxxxxxxx |ppisar@xxxxxxxxxx Flags| |fedora-review? Status|NEW |ASSIGNED --- Comment #9 from Petr Pisar <ppisar@xxxxxxxxxx> --- URL and Source0 are Ok. TODO: Source0 address does not match what upstream advertise (<https://github.com/openvkl/openvkl/archive/refs/tags/v1.3.2.tar.gz>) at <https://github.com/openvkl/openvkl/releases>. Please use that URL listed byt the upstream. Source0 archive (SHA-512: 07dad3cf13c4aae18883b02dc6b0e41ba95fffea3f76c2f77ef3b8b55c5e7a8cfe666f88fb8b079cc07af11915ee4292406e42d11123c0f66f1a10413328a911) is original. Ok. FIX: Remove the registered marks (Intel®) from Summary and Description texts <https://docs.fedoraproject.org/en-US/packaging-guidelines/#_trademarks_in_summary_or_description>. Licenses found (the files are only examples): Apache-2.0: utility/vdb/include/openvkl/utility/vdb/VdbVolumeBuffers.h BSL-1.0: testing/external/catch.hpp MIT: testing/external/half.hpp MIT OR Unlicense: examples/interactive/imgui-1.83/imstb_truetype.h OFL-1.1-RFN: examples/interactive/imgui-1.83/misc/fonts/Karla-Regular.ttf Zlib: examples/interactive/imgui-1.83/examples/libs/usynergy/uSynergy.h TODO: If any of the files is built and packaged into a binary RPM package, their licenses must be mentioned in License tag. Also a corresponding subset of third-party-programs*.txt files should be packaged with %license macro instead of %doc macro. FIX: Build-require "cmake >= 3.1", not "cmake3" (<https://docs.fedoraproject.org/en-US/packaging-guidelines/CMake/>, CMakeLists.txt:6). TODO: Constrain 'rkcommon-devel' build-dependency with '>= 1.11.0' (CMakeLists.txt:66). TODO: Constrain 'embree-devel' build-dependency with '>= 4.0.0' (CMakeLists.txt:74). TODO: Constrain 'openvdb-devel' build-dependency wiht '>= 7.0.0' (utility/vdb/CMakeLists.txt:42). TODO: Are tbb-devel and zlib-devel indeed required? They are only referred from superbuild/CMakeLists.txt which is not used. I will continue with the review later. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2179404 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
