https://bugzilla.redhat.com/show_bug.cgi?id=2182151 --- Comment #26 from Petr Pisar <ppisar@xxxxxxxxxx> --- (In reply to Chuck Lever from comment #21) > (In reply to Petr Pisar from comment #17) > > FIX: These licenses are missing from a License tag: > > GPL-2.0-only OR BSD-3-Clause: src/tlshd/netlink.h (Fedora ignores > > Linux-syscall-note "exception" > > So this is a peculiar case. > > This header is machine-generated by a kernel script > (tools/net/ynl/ynl-regen.sh) which inserts that SPDX tag in the hope that it > is a broad enough license to satisfy any open source project requirements. > > This file is copied directly from the Linux kernel > (include/uapi/linux/handshake.h) without alteration because we haven't found > a way of referring the ktls-utils build infrastructure to a Linux kernel > uapi header. Eventually src/tlshd/netlink.h is to be directly generated in > user space via the same script using a netlink spec source file. > > In other words, the license of this file is not directly under the control > of ktls-utils. I do not believe it is proper to alter the SPDX tag on this > file, and the ynl-regen.sh tool does not provide an option to specify or > alter the SPDX tag it inserts in generated files. I know the file comes from Linux. That's not a problem. In Fedora we only need to list all licenses that come into the bits stored in a binary RPM package. Hence changing "License: GPL-2.0-only" in ktls-utils.spec to "License: GPL-2.0-only AND (GPL-2.0-only OR BSD-3-Clause) AND GPL-1.0-or-later" is enough. Please update the License tag in the spec file. There is no need to change the sources. Otherwise, the updated spec file looks good. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2182151 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
