[Bug 2022555] Review Request: lv2-eq10q - LV2 audio plugin suite

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2022555



--- Comment #9 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> ---
Oh, a couple more things I missed the first time around.

----

  BuildRequires:  gtkmm24-devel

would be better written

  BuildRequires:  pkgconfig(gtkmm-2.4)

and then you can omit

  BuildRequires:  pkgconfig

See:
https://docs.fedoraproject.org/en-US/packaging-guidelines/PkgConfigBuildRequires/

----

Both of these are actually unused, and they should be removed:

  BuildRequires:  plotmm-devel
  BuildRequires:  pstreams-devel

This header-only library does not appear to be needed either:

  BuildRequires:  lv2-c++-tools-static


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2022555
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux