https://bugzilla.redhat.com/show_bug.cgi?id=2187677 --- Comment #3 from Fabio Valentini <decathorpe@xxxxxxxxx> --- (In reply to Sandro from comment #2) > Please note, this is the first time I'm reviewing a Rust package as part of > a review swap. I read through the packaging guidelines. Hopefully, I didn't > miss anything important. > > Issues/Questions > ================ > > [!]: Fully versioned dependency in subpackages if applicable. > Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rust- > pep440_rs-devel , rust-pep440_rs+default-devel , rust- > pep440_rs+pyo3-devel , rust-pep440_rs+serde-devel > > => Not sure about that one. Requires and provides in all the sub packages > look good. Yeah, this is a false positive from fedora-review, maybe we need to add some rules for Rust packages for this ... There's no "%{name}" package for this check to apply to, and all built packages are "noarch" so "%{?_isa}" doesn't make sense. The dependencies between the subpackages are automatically generated by the RPM dependency generators for Rust crates (which are correct, otherwise the dependency generator would've crashed and failed the build :)) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2187677 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
