https://bugzilla.redhat.com/show_bug.cgi?id=2187061 --- Comment #3 from Sandro <gui1ty@xxxxxxxxxxxxx> --- Thanks for the review. I dropped %fed_name. But I'm keeping %pypi_name. I actually picked that up from other Python package(r)s and I find it quite handy in referring to the upstream name, which quite often differs from the normalized name we use in Fedora. BR for pytest has been dropped, summary has been shortened, reference to upstream bug regarding missing tests has been added. > [-] Applications: A `python3-` prefix is not used Well, it's a bit of both. The package provides a standalone executable, but also a library. I believe Bottles in particular uses the library not the executable. Is it better then to name the package 'fvs' and create a python3-fvs subpackage for the library as suggested by https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_application_naming ? I'll wait for your feedback before providing updated links. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2187061 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
