https://bugzilla.redhat.com/show_bug.cgi?id=2188653 Maxwell G <maxwell@xxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |maxwell@xxxxxxx --- Comment #2 from Maxwell G <maxwell@xxxxxxx> --- The same comment about the _name macros applies here. I'd also advise against the forge macros given their current maintenance status. Also, the way you split up the subpackages doesn't make sense to me. I'd recommend creating a single vkbassalt-cli package. Otherwise, only python3-vkbassalt-cli should own the python package files (i.e. you should remove `-f %{pyproject_files}` from the main's packages `%files`) and vkbassalt-cli should have `Requires: python3-vkbassalt-cli = %{?epoch:%{epoch}:}%{version}-%{release}`. ``` Also, you should note https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_pypi_parity. This project is not packaged on PyPI. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2188653 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
