https://bugzilla.redhat.com/show_bug.cgi?id=2187061 Maxwell G <maxwell@xxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@xxxxxxxxxxxxxxxxx |maxwell@xxxxxxx CC| |maxwell@xxxxxxx Doc Type|--- |If docs needed, set a value Flags| |fedora-review? --- Comment #1 from Maxwell G <maxwell@xxxxxxx> --- I'd advise using the literal values everywhere instead of `%pypi_name` and `%fed_name`. Those macros make the specfile way less readable. That's not a blocker, though. Also, there's a BuildRequires on pytest even though that's not used at all. It should be removed. --- Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated - [x] The latest version is packaged or packaging an earlier version is justified. - [x] The License tag reflects the package contents and uses the correct identifiers. - [x] The package builds successfully in mock. - [x] Package is installable (checked by fedora-review). - [!] There are no relevant rpmlint errors. python3-fvs.noarch: E: summary-too-long File Versioning System with hash comparison and data storage to create unlinked states that can be deleted This should be shortened to < 80 characters. - [-] The package runs tests in %check. Upstream does not provide unit tests. I'd link to https://github.com/mirkobrombin/FVS/issues/2 in your specfile comment. - [!] Packager considers avoiding confusing `%foo_name` macros - [x] Libraries: The package name has a `python3-` prefix and uses the canonical project name - [-] Applications: A `python3-` prefix is not used - [x] The pyproject macros are used - [x] There are no bundled libraries - [x] The package complies with the Python and general Packaging Guidelines. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2187061 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
