https://bugzilla.redhat.com/show_bug.cgi?id=2188395 Bug ID: 2188395 Summary: Review Request: nlohmann-json - Headers-only C++ JSON implementation Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@xxxxxxxxxxxxxxxxx Reporter: kvanderr@xxxxxxxxxx QA Contact: extras-qa@xxxxxxxxxxxxxxxxx CC: package-review@xxxxxxxxxxxxxxxxxxxxxxx Target Milestone: --- Classification: Fedora Copr URL: https://copr.fedorainfracloud.org/coprs/kpvdr/nlohmann-json/ Spec URL: https://download.copr.fedorainfracloud.org/results/kpvdr/nlohmann-json/fedora-rawhide-x86_64/05082122-nlohmann-json/nlohmann-json.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/kpvdr/nlohmann-json/fedora-rawhide-x86_64/05082122-nlohmann-json/nlohmann-json-3.11.2-1.fc38.src.rpm Description: A fedora distribution of upstream project https://github.com/nlohmann/json. This is a headers-only C++ implementation of JSON which relies on C++ templates, and supports C++ 11 and 17. There are no binaries; consequently, there is only a single -devel.noarch rpm and a source rpm. The latest upstream release (3.11.2 as of this request) is built without patches. Licence is MIT. This package has already been built as a part of RHEL8 and RHEL9 as a dependency to opentelemetry-cpp (to be reviewed for Fedora release separately and also built in RHEL8 and RHEL9) which in turn is an optional dependency to qpid-proton from 0.38. Note: The current Fedora builds of qpid-proton 0.38 do not use these dependencies at present and therefore do not support opentelemetry. This package and opentelemetry-cpp together will allow this support in qpid-proton in Fedora. Fedora Account System Username: kpvdr ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [-]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. - This package contains C++ headers-only. It contains no binaries, and therefore has only a -devel.noarch rpm. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [-]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages This package is headers-only package - no binary. [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* MIT License", "MIT License", "MIT License BSD 3-Clause License GNU General Public License, Version 3 Apache License 2.0", "*No copyright* Apache License 2.0", "*No copyright* BSD 3-Clause License", "GNU General Public License, Version 3", "BSD 3-Clause License", "*No copyright* Public domain", "MIT License [generated file]", "*No copyright* MIT License Apache License 2.0". 913 files have unknown license. Detailed output of licensecheck in /var/lib/copr-rpmbuild/results/nlohmann- json/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [-]: Package uses nothing in %doc for runtime. No binaries. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [-]: Requires correct, justified where necessary. No Requires, only BuildRequires. Headers only package. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 112640 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: Reviewer should test that the package builds in mock. [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. License file included. [ ]: Final provides and requires are sane (see attachments). [x]: Package functions as described. Used in dependent package opentelemetry-cpp. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [?]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Package should compile and build into binary rpms on all supported architectures. Headers-only package. [!]: %check is present and all tests pass. Headers only package. Tests do exist, but require a large number of awkward deps from google etc. [x]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: The placement of pkgconfig(.pc) files are correct. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. Rpmlint ------- Cannot parse rpmlint output: Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 1 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.0 s Requires -------- nlohmann-json-cpp-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config cmake-filesystem Provides -------- nlohmann-json-cpp-devel: cmake(nlohmann_json) nlohmann-json-cpp-devel pkgconfig(nlohmann_json) Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23 Command line :/usr/bin/fedora-review --no-colors --prebuilt --rpm-spec --name nlohmann-json --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic Disabled plugins: Ocaml, Perl, fonts, R, Haskell, PHP, SugarActivity, Python, Java, C/C++ Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2188395 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
