https://bugzilla.redhat.com/show_bug.cgi?id=1830712 Andrea Perotti <aperotti@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(carl@xxxxxxxxxx) --- Comment #28 from Andrea Perotti <aperotti@xxxxxxxxxx> --- (In reply to Carl George 🤠 from comment #23) > Andrea, I can see that you're in the packager group now, so I'm removing > FE-NEEDSPONSOR. I can take this review. Hi Carl, all comments has been addressed, you can find new spec here: Spec URL: https://raw.githubusercontent.com/andreamtp/kronometer/master/kronometer.spec and builds are available via: # dnf copr enable andreamtp/kronometer I only have some doubts about the test part: I've build the package via `fedpkg --release f38 mockbuild` but even removing the exclusion you mentioned in your comment, I have no error and I got "No tests were found": + /usr/bin/ctest --test-dir redhat-linux-build --output-on-failure --force-new-ctest-process -j8 --verbose Internal ctest changing into directory: /builddir/build/BUILD/kronometer-2.3.0/redhat-linux-build UpdateCTestConfiguration from :/builddir/build/BUILD/kronometer-2.3.0/redhat-linux-build/DartConfiguration.tcl UpdateCTestConfiguration from :/builddir/build/BUILD/kronometer-2.3.0/redhat-linux-build/DartConfiguration.tcl Test project /builddir/build/BUILD/kronometer-2.3.0/redhat-linux-build Constructing a list of tests Updating test list for fixtures Added 0 tests to meet fixture requirements Checking test dependency graph... Checking test dependency graph end No tests were found!!! Do you have any hint in this regard? thanks -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=1830712 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
