Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gpar2 - GUI for verifying and repairing PAR and PAR2 recovery sets https://bugzilla.redhat.com/show_bug.cgi?id=426922 ------- Additional Comments From adel.gadllah@xxxxxxxxx 2007-12-29 09:07 EST ------- (In reply to comment #4) > [!] Rpmlint output: > Source RPM: empty > rpmlint of gpar2: > gpar2.x86_64: W: incoherent-version-in-changelog 0.3-1 0.3-2.fc9 > --> that's an easy one, you forgot to bump the release when doing copy/paste in > the changelog. Just fix it before uploading to cvs. fixed. > [x] Description and summary sections in the package spec file contains > translations for supported Non-English languages, if available. Please also see > my comment number 2 below > [!] Scriptlets must be sane, if used. > === Issues === > 1. according to > http://fedoraproject.org/wiki/Packaging/ScriptletSnippets?highlight=%28ScriptletSnippets%29#head-de6770dd9867fcd085a73a4700f6bcd0d10294ef > the presence of a mimetype entry in the desktop file imposes the need for > %post > update-desktop-database &> /dev/null || : > %postun > update-desktop-database &> /dev/null || : fixed > 2. According to > http://fedoraproject.org/wiki/Packaging/Guidelines#head-254ddf07aae20a23ced8cecc219d8f73926e9755, > the desktop file uses a value for Categories which no longer corresponds to our > current specifications (it should not contain Application any more). Looking at > http://standards.freedesktop.org/menu-spec/latest/apa.html I'd say Utility would > fit the bill here. fixed > 3. Don't forget to fix the changelog entry :) ;) > === Comments === > 1. I admit being puzzled by the fact that the French gpar2.mo is built, despite > gettext not being present as a BR: > checking whether NLS is requested... yes > checking for msgfmt... no > checking for gmsgfmt... no: > checking for xgettext... no > checking for msgmerge... no > And yet gpar2.mo is correctly built and included, so it's OK. OK I somehow forgot to add it while doing the last fixes but if it works this way .. ;) > 2. Just a suggestion: you could take the French description from the desktop > file and use it as %description[fr] in the spec. I can but I preffered not to do so to make keep the spec file cleaner; thats whats specspo is for afterall. > Please fix the issues above mentioned and I will approve the package. New spec / srpm: http://tgmweb.at/gadllah/gpar2.spec http://tgmweb.at/gadllah/gpar2-0.3-3.fc8.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review