https://bugzilla.redhat.com/show_bug.cgi?id=2184237 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |decathorpe@xxxxxxxxx --- Comment #12 from Fabio Valentini <decathorpe@xxxxxxxxx> --- > export CARGO_HOME=.cargo RUSTC_BOOTSTRAP=1 RUSTFLAGS='%{build_rustflags}' This looks a bit fishy to me ... 1. Is setting "CARGO_HOME=.cargo" really necessary? I guess the "%cargo_build" macro does this as well, but none of the other Rusty Python packages in Fedora set this (I checked python-cryptography, fapolicy-analyzer). 2. Setting "RUSTC_BOOTSTRAP=1" should not be needed. It's an internal implementation detail of the Rust packaging macros to work around some shortcomings of dependency resolution. It basically enables unstable / nightly-only features on the stable version of the Rust compiler / cargo (because we use `-Zavoid-dev-deps` in the `%cargo_install` macro). But you should never need to add this for any other reasons. If you *do* need it, then your project actually requires a nightly Rust compiler, and we don't have that. Since I don't think orjson requires "Rust Nightly", you should remove this. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2184237 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
