Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libpar2 - Library for performing common tasks related to PAR recovery sets https://bugzilla.redhat.com/show_bug.cgi?id=426919 wolfy@xxxxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From wolfy@xxxxxxxxxxxxxxxxxx 2007-12-29 07:06 EST ------- Package Review ============== Key: - = N/A x = Check ! = Problem ? = Not evaluated === REQUIRED ITEMS === [x] Package is named according to the Package Naming Guidelines. [x] Spec file name must match the base package %{name}, in the format %{name}.spec. [x] Package meets the Packaging Guidelines. [x] Package successfully compiles and builds into binary rpms on at least one supported architecture. Tested on:x86_64 [!] Rpmlint output: Source RPM:empty rpmlint of libpar2: libpar2.x86_64: W: spurious-executable-perm /usr/share/doc/libpar2-0.2/ChangeLog -> please chmod -x (or use %attr in %files... as you prefer) libpar2.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/libpar2-0.2/README libpar2.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/libpar2-0.2/ROADMAP libpar2.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/libpar2-0.2/AUTHORS -> just cosmetic. please fix them if you feel like doing it. Since they come with CRLF from upstream, it's entirely up to you. [x] Package is not relocatable. [x] Buildroot is correct (%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)) [x] Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x] License field in the package spec file matches the actual license. License type:GPLv2+ [x] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x] Spec file is legible and written in American English. [x] Sources used to build the package matches the upstream source, as provided in the spec URL. SHA1SUM of package: 4b3da928ea6097a8299aadafa703fc6d59bdfb4b libpar2-0.2.tar.gz [x] Package is not known to require ExcludeArch [x] All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [-] The spec file handles locales properly. [x] ldconfig called in %post and %postun if required. [x] Package must own all directories that it creates. [x] Package requires other packages for directories it uses. [x] Package does not contain duplicates in %files. [x] Permissions on files are set properly. [x] Package has a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). [x] Package consistently uses macros. [x] Package contains code, or permissable content. [-] Large documentation files are in a -doc subpackage, if required. [x] Package uses nothing in %doc for runtime. [x] Header files in -devel subpackage, if present. [-] Static libraries in -devel subpackage, if present. [-] Package requires pkgconfig, if .pc files are present. [x] Development .so files in -devel subpackage, if present. [x] Fully versioned dependency in subpackages, if present. [x] Package does not contain any libtool archives (.la). [-] Package contains a properly installed %{name}.desktop file if it is a GUI application. [x] Package does not own files or directories owned by other packages. === SUGGESTED ITEMS === [x] Latest version is packaged. [x] Package does not include license text files separate from upstream. [-] Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x] Reviewer should test that the package builds in mock. Tested on:devel/x86_64 [x] Package should compile and build into binary rpms on all supported architectures. Tested on:devel/x86_64 [x] Package functions as described. [x] Scriptlets must be sane, if used. [-] The placement of pkgconfig(.pc) files are correct. [-] File based requires are sane. === Issues === 1. none ================ *** APPROVED *** ================ If I were you I would drop the makefile patch and use make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p" which has the advantage of not being dependent on upstream's Makefile. Up to you to decide. Once again, sorry for forgetting to attach my spec :( -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review