https://bugzilla.redhat.com/show_bug.cgi?id=2183742 Aleksei Bavshin <alebastr89@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value CC| |alebastr89@xxxxxxxxx Flags| |fedora-review+ Status|NEW |POST Assignee|nobody@xxxxxxxxxxxxxxxxx |alebastr89@xxxxxxxxx --- Comment #2 from Aleksei Bavshin <alebastr89@xxxxxxxxx> --- Approved. > # * missing dev-dependencies: snapbox Good thing: tests currently do not require snapbox. Bad thing: that's because `include.workspace = true` in Cargo.toml resolves to the list from https://github.com/clap-rs/clap/blob/0.2.10/Cargo.toml#L17 which does not include 'tests/**/*' ¯\_(ツ)_/¯ There are no tests to run, but if there were any, they would still require snapbox. With that in mind, `%bcond_with check` seems fine to me. You might want to check with the clap upstream if the omission was intentional though. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2183742 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
