https://bugzilla.redhat.com/show_bug.cgi?id=2184004 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+ Status|NEW |POST Assignee|nobody@xxxxxxxxxxxxxxxxx |decathorpe@xxxxxxxxx Doc Type|--- |If docs needed, set a value CC| |decathorpe@xxxxxxxxx --- Comment #2 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide ! test suite is run and all unit tests pass (tests are disabled with link to upstream bug report) - latest version of the crate is packaged - license matches upstream specification and is acceptable for Fedora ? license files are included with %license in %files (upstream unresponsive, standard license files for Apache-2.0 and MIT included manually) - package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - add @rust-sig with "commit" access as package co-maintainer - set bugzilla assignee overrides to @rust-sig (optional) - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - track package in koschei for all built branches === Non-blocking issues, please address them before importing the package: 1. Exclude some CI files from the package, i.e. by adding this to Cargo.toml's [package] table: exclude = ["/ci/", "/azure-pipelines.yml"] 2. Include a link the upstream bug report about the 32-bit test failures in the spec file: https://github.com/fitzgen/associative-cache/issues/15 3. If you can, provide more details than "Doctests are broken". It looks like many of them are not compilable / runnable, but not annotated with "ignore", i.e. like this: ```ignore this is not valid rust code ``` 4. You can de-duplicate the license files. Right now they are installed twice (once in %crate_instdir, and once in %_licensedir). You can pass an absolute path to the %license macro instead so the files are not copied to %_licensedir, i.e. %license %{crate_instdir}/LICENSE-APACHE %license %{crate_instdir}/LICENSE-MIT -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2184004 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
