https://bugzilla.redhat.com/show_bug.cgi?id=2183331 --- Comment #3 from Fabio Valentini <decathorpe@xxxxxxxxx> --- (In reply to Aleksei Bavshin from comment #2) > Looks good with minor comments. > > > # * missing dev-dependencies: circular, snapbox, term-transcript > > You can run `%cargo_test -- --doc` and `%cargo_test -- --lib` even without > the listed packages. In fact, most of dev-dependencies are there only for > examples. And for `debug`... Huh, you're right. I've removed those dependencies and added running unit and doc tests. > > %package -n %{name}+unstable-doc-devel > > Does this feature have any use other than in docs.rs documentation? Well, > it's not harmful either so IMO it's fine to leave it. Right, it's not harmful since it doesn't pull in any extra dependencies ... Updated files behind the same URLs. [fedora-review-service-build] -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2183331 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
