https://bugzilla.redhat.com/show_bug.cgi?id=2176241 Mikel Olasagasti Uranga <mikel@xxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(mikel@olasagasti. | |info) | --- Comment #21 from Mikel Olasagasti Uranga <mikel@xxxxxxxxxxxxxxx> --- Sorry Link, I've been busy and I couldn't update you earlier. Thanks for detailing how you create the srpm file, now I understand why the spec file differs from the one you want to use. I use `rpmbuild -bs foo.spec` to create the srpm and then upload the result and the original spec. The spec and the spec inside the sprm files are the same in that case. All the reviews I did previously didn't had the sections we were discussing about, so that was confusing me. My reviewed list: https://bugzilla.redhat.com/buglist.cgi?classification=Fedora&columnlist=product%2Ccomponent%2Cassigned_to%2Cbug_status%2Cshort_desc%2Cchangeddate%2Cbug_severity&component=Package+Review&email1=mikel%40olasagasti.info&emailassigned_to1=1&emailtype1=substring&f1=flagtypes.name&o1=substring&order=status%2C+last_change_time%2C+assigned_to%2C+id%2C+&product=Fedora&query_format=advanced&resolution=---&resolution=CURRENTRELEASE&resolution=RAWHIDE&resolution=ERRATA&resolution=NEXTRELEASE&resolution=CANTFIX&v1=fedora-review The spec is fine, will approve it now. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2176241 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
