https://bugzilla.redhat.com/show_bug.cgi?id=2119983 Simone Caronni <negativo17@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(negativo17@gmail. | |com) | --- Comment #62 from Simone Caronni <negativo17@xxxxxxxxx> --- (In reply to Frank Crawford from comment #60) > Oh, looking through the rpmlint output attached to the review, there are a > batch of little items that I see need fixing. > > > c-icap.x86_64: E: logrotate-user-writable-log-dir /var/log/c-icap c-icap:c-icap 0750 > > This needs an > > su c-icap c-icap > in c-icap.logrotate This is correct, the user should be able to write to it. Another option is to make it root:c-icap 0770, in this case the error stops but is not that different. Other packages in fedora do a mix of those. > > c-icap-libs.x86_64: W: crypto-policy-non-compliance-openssl /usr/lib64/libicapapi.so.0.0.1 SSL_CTX_set_cipher_list > > This is trickier, but covered in > https://docs.fedoraproject.org/en-US/packaging-guidelines/CryptoPolicies/ > and effectively says the default be > > PROFILE=SYSTEM > in the c-icap-conf but I'm not sure how that can be added into there. Yes, but this is a warning and it should be tackled upstream, i'll open a bug. > And also: > > c-icap.x86_64: W: unused-direct-shlib-dependency /usr/lib64/c_icap/dnsbl_tables.so /lib64/libatomic.so.1 > > (and many more) may be covered by > https://fedoraproject.org/wiki/Common_Rpmlint_issues#unused-direct-shlib- > dependency > > And finally: > > c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/dnsbl_tables.so CI_DEBUG_LEVEL (/usr/lib64/c_icap/dnsbl_tables.so) > > which I'm not sure, as that looks to be well define. These have gone with the latest rebase which also fixed the autotools deprecated macros (https://github.com/c-icap/c-icap-server/issues/50). c-icap.x86_64: W: post-without-tmpfile-creation /usr/lib/tmpfiles.d/c-icap.conf c-icap.x86_64: W: non-standard-uid /run/c-icap c-icap c-icap.x86_64: W: non-standard-uid /var/log/c-icap c-icap c-icap.x86_64: W: non-standard-gid /etc/c-icap c-icap c-icap.x86_64: W: non-standard-gid /etc/c-icap/c-icap.conf c-icap c-icap.x86_64: W: non-standard-gid /etc/c-icap/c-icap.magic c-icap c-icap.x86_64: W: non-standard-gid /run/c-icap c-icap c-icap.x86_64: W: non-standard-gid /var/log/c-icap c-icap c-icap.x86_64: E: non-standard-dir-perm /etc/c-icap 750 c-icap.x86_64: E: non-standard-dir-perm /var/log/c-icap 750 c-icap.x86_64: E: non-readable /etc/c-icap/c-icap.conf 640 c-icap.x86_64: E: non-readable /etc/c-icap/c-icap.magic 640 c-icap-perl.x86_64: W: no-documentation c-icap.x86_64: E: logrotate-user-writable-log-dir /var/log/c-icap c-icap:c-icap 0750 c-icap-libs.x86_64: W: crypto-policy-non-compliance-openssl /usr/lib64/libicapapi.so.0.0.1 SSL_CTX_set_cipher_list (In reply to Frank Crawford from comment #59) > @negativo17@xxxxxxxxx Fedora have now deprecated pcre-devel as of Fedora 38, > and so we should get it converted to pcre2-devel! I have no idea how much > trouble that is, but can you look at it. > > From what I can tell, that should be the last issue. I've opened an issue on the project for this: https://github.com/c-icap/c-icap-server/issues/51 Spec URL: https://slaanesh.fedorapeople.org/c-icap.spec SRPM URL: https://slaanesh.fedorapeople.org/c-icap-0.5.11-10.20230319git2e36bb8.fc37.src.rpm * Fri Mar 31 2023 Simone Caronni <negativo17@xxxxxxxxx> - 0.5.11-10.20230319git2e36bb8 - Update to latest snapshot. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2119983 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
