https://bugzilla.redhat.com/show_bug.cgi?id=2182963 --- Comment #8 from Parag AN(पराग) <panemade@xxxxxxxxx> --- [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT License", "Unknown or generated". 14 files have unknown license. Detailed output of licensecheck in /var/lib/copr- rpmbuild/results/fonts-compare/licensecheck.txt I see https://github.com/sudipshil9862/fonts-compare/blob/main/LICENSE says "MIT" license but you wrote in SPEC "GPLv3" which is wrong then [!]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/fonts-compare Why you install like this install -D -m 755 fonts_compare.py %{buildroot}%{_datadir}/%{name}/fonts_compare.py and not just install -D -m 755 fonts_compare.py %{buildroot}%{_datadir}/%{name}/ Also, why not write a build-system for your project like using autotools or Cmake? [ ]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/icons/hicolor/256x256/apps, /usr/share/icons/hicolor, /usr/share/icons/hicolor/16x16/apps, /usr/share/icons/hicolor/22x22/apps, /usr/share/icons/hicolor/32x32/apps, /usr/share/icons/hicolor/32x32, /usr/share/icons/hicolor/64x64, /usr/share/icons/hicolor/128x128, /usr/share/icons/hicolor/22x22, /usr/share/icons/hicolor/128x128/apps, /usr/share/icons/hicolor/scalable/apps, /usr/share/fonts-compare, /usr/share/icons/hicolor/48x48/apps, /usr/share/icons/hicolor/64x64/apps, /usr/share/icons/hicolor/256x256, /usr/share/icons/hicolor/48x48, /usr/share/icons/hicolor/scalable, /usr/share/icons/hicolor/16x16 Same applies as suggested in above point. Why not write like install -D -m 644 logo/16x16/fonts-compare.png %{buildroot}/%{_datadir}/icons/hicolor/16x16/apps/ [!] rpmlint output says fonts-compare.noarch: W: no-manual-page-for-binary fonts-compare ==> This is okay but maybe you want to write man-page for your tool in upstream fonts-compare.spec:13: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 13) ==> You can check this in your SPEC editor fonts-compare.noarch: E: description-line-too-long Fonts-Compare is a tool that enables individuals to compare various fonts in a particular language. fonts-compare.src: E: description-line-too-long Fonts-Compare is a tool that enables individuals to compare various fonts in a particular language. ==> split description line in 2 lines wrapping per line 80 characters -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2182963 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
