https://bugzilla.redhat.com/show_bug.cgi?id=2176933 --- Comment #5 from Miro Hrončok <mhroncok@xxxxxxxxxx> --- > It doesn't though. If I remove that, the build fails: ... I see. IMHO this is a bug in upstream packaging. The setup.py script has: from a11y_pygments.utils.utils import find_all_themes_packages Hence before we can execute setup.py, we already need to have install_requires installed. A possible upstream fix (if you intend to persuade it) is to introduce a pyproject.toml file with pygments listed in [build-system].requires. Something like: [build-system] requires = ["setuptools", "pygments >= 1.5"] build-backend = "setuptools.build_meta" A better fix is not to import the package from setup.py, but that might be tricky. (This might deserve a comment near the manual BR.) > There are no export statements. In spite of the name of the macro, those are shell variables, not environment variables. The intended usage is: %{py3_test_envvars} %{python3} test/run_tests.py I had no idea that such variables are not considered "environment" when introduced the macro (and nobody who discussed or reviewed it had that idea neither). The macro will be documented in the guidelines. Do you think it needs to be renamed? > I wonder if I should use traditional Release numbering and changelogs while a package is going through review No need. Updating the same link is fine for me. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2176933 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
